system: blocking delay should actually call delay()

avoid optimizing out function call when `&&` comparison is always false
resolve #2555

code/espurna/system.cpp

@@ -315,7 +315,7 @@ bool tryDelay(CoreClock::time_point start, CoreClock::duration timeout, CoreCloc
 
 void blockingDelay(CoreClock::duration timeout, CoreClock::duration interval) {
     blockingDelay(timeout, interval, []() {
-        return false;
+        return true;
     });
 }
 

code/espurna/system.h

@@ -189,7 +189,14 @@ bool tryDelay(CoreClock::time_point start, CoreClock::duration timeout, CoreCloc
 template <typename T>
 void blockingDelay(CoreClock::duration timeout, CoreClock::duration interval, T&& blocked) {
     const auto start = CoreClock::now();
-    while (!tryDelay(start, timeout, interval) && blocked()) {
+    for (;;) {
+        if (tryDelay(start, timeout, interval)) {
+            break;
+        }
+
+        if (!blocked()) {
+            break;
+        }
     }
 }