From 261748e5e81cdc6de99405b52b8b823768ac6ab8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Xose=20P=C3=A9rez?= <xose.perez@gmail.com>
Date: Sat, 8 Sep 2018 18:08:58 +0200
Subject: [PATCH] Option to disable password in telnet connections, default is
 enabled

---
 code/espurna/config/general.h |  4 ++++
 code/espurna/telnet.ino       | 44 ++++++++++++++++++++++-------------
 2 files changed, 32 insertions(+), 16 deletions(-)

diff --git a/code/espurna/config/general.h b/code/espurna/config/general.h
index 103e5a50..4df05781 100644
--- a/code/espurna/config/general.h
+++ b/code/espurna/config/general.h
@@ -110,6 +110,10 @@
 #define TELNET_STA              0               // By default, disallow connections via STA interface
 #endif
 
+#ifndef TELNET_PASSWORD
+#define TELNET_PASSWORD         1               // Request password to start telnet session by default
+#endif
+
 #define TELNET_PORT             23              // Port to listen to telnet clients
 #define TELNET_MAX_CLIENTS      1               // Max number of concurrent telnet clients
 
diff --git a/code/espurna/telnet.ino b/code/espurna/telnet.ino
index dd283194..87811874 100644
--- a/code/espurna/telnet.ino
+++ b/code/espurna/telnet.ino
@@ -14,8 +14,10 @@ Parts of the code have been borrowed from Thomas Sarlandie's NetServer
 
 AsyncServer * _telnetServer;
 AsyncClient * _telnetClients[TELNET_MAX_CLIENTS];
-bool _authenticated[TELNET_MAX_CLIENTS];
 bool _telnetFirst = true;
+#if TELNET_PASSWORD
+    bool _authenticated[TELNET_MAX_CLIENTS];
+#endif
 
 // -----------------------------------------------------------------------------
 // Private methods
@@ -53,10 +55,14 @@ unsigned char _telnetWrite(void *data, size_t len) {
     unsigned char count = 0;
     for (unsigned char i = 0; i < TELNET_MAX_CLIENTS; i++) {
 
-        // Do not send broadcast messages to unauthenticated clients
-        if (_authenticated[i]) {
+        #if TELNET_PASSWORD
+            // Do not send broadcast messages to unauthenticated clients
+            if (_authenticated[i]) {
+                if (_telnetWrite(i, data, len)) ++count;
+            }
+        #else
             if (_telnetWrite(i, data, len)) ++count;
-        }
+        #endif
 
     }
     return count;
@@ -91,17 +97,19 @@ void _telnetData(unsigned char clientId, void *data, size_t len) {
     }
 
     // Password
-    if (!_authenticated[clientId]) {
-        String password = getAdminPass();
-        if (strncmp(p, password.c_str(), password.length()) == 0) {
-            DEBUG_MSG_P(PSTR("[TELNET] Client #%d authenticated\n"), clientId);
-            _telnetWrite(clientId, "Welcome!\n");
-            _authenticated[clientId] = true;
-        } else {
-            _telnetWrite(clientId, "Password: ");
+    #if TELNET_PASSWORD
+        if (!_authenticated[clientId]) {
+            String password = getAdminPass();
+            if (strncmp(p, password.c_str(), password.length()) == 0) {
+                DEBUG_MSG_P(PSTR("[TELNET] Client #%d authenticated\n"), clientId);
+                _telnetWrite(clientId, "Welcome!\n");
+                _authenticated[clientId] = true;
+            } else {
+                _telnetWrite(clientId, "Password: ");
+            }
+            return;
         }
-        return;
-    }
+    #endif // TELNET_PASSWORD
 
     // Inject command
     settingsInject(data, len);
@@ -167,10 +175,14 @@ void _telnetNewClient(AsyncClient *client) {
                 debugClearCrashInfo();
             #endif
 
+            #if TELNET_PASSWORD
+                _authenticated[i] = false;
+                _telnetWrite(i, "Password: ");
+            #endif
+
             _telnetFirst = true;
-            _authenticated[i] = false;
-            _telnetWrite(i, "Password: ");
             wifiReconnectCheck();
+
             return;
 
         }