Browse Source

Fix #17. Moved static variable 'pending' to class variable '_clicked'

fastled
Xose Pérez 8 years ago
parent
commit
3df5cef97b
2 changed files with 10 additions and 7 deletions
  1. +9
    -7
      code/lib/DebounceEvent/DebounceEvent.cpp
  2. +1
    -0
      code/lib/DebounceEvent/DebounceEvent.h

+ 9
- 7
code/lib/DebounceEvent/DebounceEvent.cpp View File

@ -45,7 +45,6 @@ DebounceEvent::DebounceEvent(uint8_t pin, uint8_t defaultStatus, unsigned long d
bool DebounceEvent::loop() { bool DebounceEvent::loop() {
// holds whether status has changed or not // holds whether status has changed or not
static bool pending = false;
bool changed = false; bool changed = false;
_event = EVENT_NONE; _event = EVENT_NONE;
@ -57,7 +56,7 @@ bool DebounceEvent::loop() {
if (newStatus != _status) { if (newStatus != _status) {
changed = true; changed = true;
pending = false;
_clicked = false;
_status = newStatus; _status = newStatus;
// released // released
@ -69,9 +68,13 @@ bool DebounceEvent::loop() {
} else if (millis() - _last_start < DOUBLE_CLICK_DELAY ) { } else if (millis() - _last_start < DOUBLE_CLICK_DELAY ) {
_event = EVENT_DOUBLE_CLICK; _event = EVENT_DOUBLE_CLICK;
} else { } else {
// We are not setting the event type here because we still don't
// know what kind of event it will be (it might be a double click).
// Instead we are setting the _clicked variable to check later
_clicked = true;
changed = false; changed = false;
pending = true;
//_event = EVENT_SINGLE_CLICK;
} }
// pressed // pressed
@ -86,8 +89,8 @@ bool DebounceEvent::loop() {
} }
} }
if (pending && (millis() - _this_start > DOUBLE_CLICK_DELAY) && (!changed) && (_status == _defaultStatus)) {
pending = false;
if (_clicked && (millis() - _this_start > DOUBLE_CLICK_DELAY) && (!changed) && (_status == _defaultStatus)) {
_clicked = false;
changed = true; changed = true;
_event = EVENT_SINGLE_CLICK; _event = EVENT_SINGLE_CLICK;
} }
@ -99,7 +102,6 @@ bool DebounceEvent::loop() {
} }
} }
return changed; return changed;
} }


+ 1
- 0
code/lib/DebounceEvent/DebounceEvent.h View File

@ -42,6 +42,7 @@ class DebounceEvent {
uint8_t _pin; uint8_t _pin;
uint8_t _status; uint8_t _status;
uint8_t _event; uint8_t _event;
bool _clicked = false;
unsigned long _this_start; unsigned long _this_start;
unsigned long _last_start; unsigned long _last_start;
uint8_t _defaultStatus; uint8_t _defaultStatus;


Loading…
Cancel
Save