Browse Source

Apply suggestions from code review

Co-authored-by: Drashna Jaelre <drashna@live.com>
pull/15759/head
Kan-Ru Chen 2 years ago
committed by GitHub
parent
commit
2236308d92
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 10 additions and 10 deletions
  1. +0
    -3
      keyboards/hhkb/yang/config.h
  2. +4
    -2
      keyboards/hhkb/yang/keymaps/default/keymap.c
  3. +5
    -3
      keyboards/hhkb/yang/keymaps/kanru/keymap.c
  4. +1
    -2
      keyboards/hhkb/yang/rules.mk

+ 0
- 3
keyboards/hhkb/yang/config.h View File

@ -119,9 +119,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
//#define NO_ACTION_TAPPING
//#define NO_ACTION_ONESHOT
/* disable these deprecated features by default */
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION
/* Bootmagic Lite key configuration */
//#define BOOTMAGIC_LITE_ROW 0


+ 4
- 2
keyboards/hhkb/yang/keymaps/default/keymap.c View File

@ -18,8 +18,10 @@
*/
#include QMK_KEYBOARD_H
#define BASE 0
#define HHKB 1
enum custom_layers {
BASE,
HHKB,
};
const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {


+ 5
- 3
keyboards/hhkb/yang/keymaps/kanru/keymap.c View File

@ -19,9 +19,11 @@
#include QMK_KEYBOARD_H
#include <stdio.h>
#define BASE 0
#define HHKB 1
#define MOUSE 2
enum custom_layers {
BASE,
HHKB,
MOUSE,
};
#define BATTERY_FULL 550
#define BATTERY_EMPTY 326


+ 1
- 2
keyboards/hhkb/yang/rules.mk View File

@ -15,13 +15,12 @@ MOUSEKEY_ENABLE = yes # Mouse keys
EXTRAKEY_ENABLE = yes # Audio control and System control
CONSOLE_ENABLE = no # Console for debug
COMMAND_ENABLE = yes # Commands for debug and configuration
# if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work
NKRO_ENABLE = no # USB Nkey Rollover
LAYOUTS = 60_hhkb
# Disable bluetooth until the UART code is merged
# BLUETOOTH = AdafruitBLE_UART
BLUETOOTH_DRIVER = BluefruitLE
# Custom matrix file for the HHKB
CUSTOM_MATRIX = lite


Loading…
Cancel
Save