Browse Source

Apply suggestions from code review

changes suggested by fauxpark

Co-authored-by: Ryan <fauxpark@gmail.com>
pull/15909/head
ymlmkb 2 years ago
committed by GitHub
parent
commit
561b4c2d42
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 9 additions and 11 deletions
  1. +1
    -1
      keyboards/keebmonkey/kbmg68/info.json
  2. +4
    -4
      keyboards/keebmonkey/kbmg68/kbmg68.h
  3. +3
    -3
      keyboards/keebmonkey/kbmg68/readme.md
  4. +1
    -3
      keyboards/keebmonkey/kbmg68/rules.mk

+ 1
- 1
keyboards/keebmonkey/kbmg68/info.json View File

@ -3,7 +3,7 @@
"url": "", "url": "",
"maintainer": "qmk", "maintainer": "qmk",
"layouts": { "layouts": {
"LAYOUT": {
"LAYOUT_65_ansi": {
"layout": [ "layout": [
{ "label": "K00 (B1,B6)", "x": 0, "y": 0 }, { "label": "K00 (B1,B6)", "x": 0, "y": 0 },
{ "label": "K01 (B1,B7)", "x": 1, "y": 0 }, { "label": "K01 (B1,B7)", "x": 1, "y": 0 },


+ 4
- 4
keyboards/keebmonkey/kbmg68/kbmg68.h View File

@ -20,12 +20,12 @@
#define XXX KC_NO #define XXX KC_NO
#define LAYOUT( \
#define LAYOUT_65_ansi( \
K00, K01, K02, K03, K04, K05, K06, K07, K08, K09, K0A, K0B, K0C, K0E, K0F, \ K00, K01, K02, K03, K04, K05, K06, K07, K08, K09, K0A, K0B, K0C, K0E, K0F, \
K10, K12, K13, K14, K15, K16, K17, K18, K19, K1A, K1B, K1C, K1D, K1E, K1F, \ K10, K12, K13, K14, K15, K16, K17, K18, K19, K1A, K1B, K1C, K1D, K1E, K1F, \
K20, K22, K23, K24, K25, K26, K27, K28, K29, K2A, K2B, K2C, K2D, K2F, \
K31, K32, K33, K34, K35, K36, K37, K38, K39, K3A, K3B, K3D, K3E, K3F, \
K40, K41, K43, K46, K4A, K4B, K4C, K4D, K4E, K4F \
K20, K22, K23, K24, K25, K26, K27, K28, K29, K2A, K2B, K2C, K2D, K2F, \
K31, K32, K33, K34, K35, K36, K37, K38, K39, K3A, K3B, K3D, K3E, K3F, \
K40, K41, K43, K46, K4A, K4B, K4C, K4D, K4E, K4F \
) { \ ) { \
{ K00, K01, K02, K03, K04, K05, K06, K07, K08, K09, K0A, K0B, K0C, XXX, K0E, K0F }, \ { K00, K01, K02, K03, K04, K05, K06, K07, K08, K09, K0A, K0B, K0C, XXX, K0E, K0F }, \
{ K10, XXX, K12, K13, K14, K15, K16, K17, K18, K19, K1A, K1B, K1C, K1D, K1E, K1F }, \ { K10, XXX, K12, K13, K14, K15, K16, K17, K18, K19, K1A, K1B, K1C, K1D, K1E, K1F }, \


+ 3
- 3
keyboards/keebmonkey/kbmg68/readme.md View File

@ -4,9 +4,9 @@
The Keebmonkey KBMG68 should be the cheapest gasket keyboard you can ever have. Both the plate and the PCB are gasket mounted, resulting in a deep thocky sound. The shell of the kit is made of 6-layers of acrylic boards, leaving huge space for modding and continuous improvements (even though this kit already sounds perfect when it's out of the box). The Keebmonkey KBMG68 should be the cheapest gasket keyboard you can ever have. Both the plate and the PCB are gasket mounted, resulting in a deep thocky sound. The shell of the kit is made of 6-layers of acrylic boards, leaving huge space for modding and continuous improvements (even though this kit already sounds perfect when it's out of the box).
Keyboard Maintainer: Unknown
Hardware Supported: Unknown
Hardware Availability: [Keebmonkey KBMG68 Double Mounted Gasket Keyboard Kit](https://www.keebmonkey.com/products/kbmg68)
* Keyboard Maintainer: Unknown
* Hardware Supported: Unknown
* Hardware Availability: [Keebmonkey KBMG68 Double Mounted Gasket Keyboard Kit](https://www.keebmonkey.com/products/kbmg68)
## Instructions ## Instructions


+ 1
- 3
keyboards/keebmonkey/kbmg68/rules.mk View File

@ -15,8 +15,6 @@ COMMAND_ENABLE = no # Commands for debug and configuration
NKRO_ENABLE = no # Enable N-Key Rollover NKRO_ENABLE = no # Enable N-Key Rollover
BACKLIGHT_ENABLE = no # Enable keyboard backlight functionality BACKLIGHT_ENABLE = no # Enable keyboard backlight functionality
RGBLIGHT_ENABLE = yes # Enable keyboard RGB underglow RGBLIGHT_ENABLE = yes # Enable keyboard RGB underglow
BLUETOOTH_ENABLE = no # Enable Bluetooth
AUDIO_ENABLE = no # Audio output AUDIO_ENABLE = no # Audio output
# generated by KBFirmware JSON to QMK Parser
# https://noroadsleft.github.io/kbf_qmk_converter/
LAYOUTS = 65_ansi

Loading…
Cancel
Save