Browse Source

rename I2C_MASTER_RIGHT to MASTER_RIGHT since this works for serial as well

pull/1070/head
Jimmy Chan 7 years ago
parent
commit
56d2198b3d
4 changed files with 10 additions and 6 deletions
  1. +4
    -3
      keyboards/lets_split/keymaps/i2c/config.h
  2. +2
    -0
      keyboards/lets_split/keymaps/serial/config.h
  3. +2
    -2
      keyboards/lets_split/readme.md
  4. +2
    -1
      keyboards/lets_split/split_util.c

+ 4
- 3
keyboards/lets_split/keymaps/i2c/config.h View File

@ -16,8 +16,9 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
#define USE_I2C
#define I2C_MASTER_LEFT
// #define I2C_MASTER_RIGHT
#define MASTER_LEFT
// #define _MASTER_RIGHT
// #define EE_HANDS
#ifdef SUBPROJECT_rev1
#include "../../rev1/config.h"
@ -27,4 +28,4 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#endif
#ifdef SUBPROJECT_rev2fliphalf
#include "../../rev2fliphalf/config.h"
#endif
#endif

+ 2
- 0
keyboards/lets_split/keymaps/serial/config.h View File

@ -18,6 +18,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define USE_SERIAL
#define MASTER_LEFT
// #define _MASTER_RIGHT
// #define EE_HANDS


+ 2
- 2
keyboards/lets_split/readme.md View File

@ -123,12 +123,12 @@ The EEPROM approach requires additional setup (flashing the eeeprom) but allows
The USB cable approach is easier to setup and if you just want the usb cable on the left board, you do not need to do anything extra.
### Setting the left hand as master
If you always plug the usb cable into the left board, nothing extra is needed as this is the default. Comment out `EE_HANDS` and comment out `I2C_MASTER_RIGHT` if for some reason it was set.
If you always plug the usb cable into the left board, nothing extra is needed as this is the default. Comment out `EE_HANDS` and comment out `I2C_MASTER_RIGHT` or `MASTER_RIGHT` if for some reason it was set.
### Setting the right hand as master
If you always plug the usb cable into the right board, add an extra flag to your `config.h`
```
#define I2C_MASTER_RIGHT
#define MASTER_RIGHT
```
### Setting EE_hands to use either hands as master


+ 2
- 1
keyboards/lets_split/split_util.c View File

@ -21,7 +21,8 @@ static void setup_handedness(void) {
#ifdef EE_HANDS
isLeftHand = eeprom_read_byte(EECONFIG_HANDEDNESS);
#else
#ifdef I2C_MASTER_RIGHT
// I2C_MASTER_RIGHT is deprecated use MASTER_RIGHT instead since this works for both serial and i2c
#if defined(I2C_MASTER_RIGHT) || defined(MASTER_RIGHT)
isLeftHand = !has_usb();
#else
isLeftHand = has_usb();


Loading…
Cancel
Save