From 94432528a628b8ce77176c2e6511135d17d22b0e Mon Sep 17 00:00:00 2001 From: Johannes Jansson Date: Sun, 29 Aug 2021 22:19:29 +0200 Subject: [PATCH] Apply suggestions from code review --- .../aetreus/keymaps/default/keymap.c | 16 ++++++++++++++ .../handwired/aetreus/keymaps/janzon/keymap.c | 22 ++++++++++++++----- .../handwired/aetreus/keymaps/via/keymap.c | 16 ++++++++++++++ keyboards/handwired/aetreus/rules.mk | 12 ---------- 4 files changed, 48 insertions(+), 18 deletions(-) diff --git a/keyboards/handwired/aetreus/keymaps/default/keymap.c b/keyboards/handwired/aetreus/keymaps/default/keymap.c index 5c387de998e..6117746751c 100644 --- a/keyboards/handwired/aetreus/keymaps/default/keymap.c +++ b/keyboards/handwired/aetreus/keymaps/default/keymap.c @@ -1,3 +1,19 @@ +/* Copyright 2021 Johannes Jansson + * + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation, either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see . + */ + #include QMK_KEYBOARD_H // MOD_KC diff --git a/keyboards/handwired/aetreus/keymaps/janzon/keymap.c b/keyboards/handwired/aetreus/keymaps/janzon/keymap.c index 17e59f9c0e3..cda609b9b68 100644 --- a/keyboards/handwired/aetreus/keymaps/janzon/keymap.c +++ b/keyboards/handwired/aetreus/keymaps/janzon/keymap.c @@ -1,5 +1,20 @@ -#include QMK_KEYBOARD_H +/* Copyright 2021 Johannes Jansson + * + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation, either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see . + */ +#include QMK_KEYBOARD_H // Layers #define _QWERTY 0 @@ -149,11 +164,6 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { ) }; -void persistent_default_layer_set(uint16_t default_layer) { - eeconfig_update_default_layer(default_layer); - default_layer_set(default_layer); -} - bool process_record_user(uint16_t keycode, keyrecord_t *record) { uint8_t shift_pressed = get_mods() & ((MOD_BIT(KC_LSFT) | MOD_BIT(KC_RSFT))); // uint8_t alt_pressed = get_mods() & ((MOD_BIT(KC_LALT) | MOD_BIT(KC_RALT))); diff --git a/keyboards/handwired/aetreus/keymaps/via/keymap.c b/keyboards/handwired/aetreus/keymaps/via/keymap.c index 467e775d49c..16acb07121e 100644 --- a/keyboards/handwired/aetreus/keymaps/via/keymap.c +++ b/keyboards/handwired/aetreus/keymaps/via/keymap.c @@ -1,3 +1,19 @@ +/* Copyright 2021 Johannes Jansson + * + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation, either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see . + */ + #include QMK_KEYBOARD_H // MOD_KC diff --git a/keyboards/handwired/aetreus/rules.mk b/keyboards/handwired/aetreus/rules.mk index d2fff0db8af..09e42fd46d3 100644 --- a/keyboards/handwired/aetreus/rules.mk +++ b/keyboards/handwired/aetreus/rules.mk @@ -1,19 +1,7 @@ -# MCU name MCU = atmega32u4 - -# Bootloader selection -# Teensy halfkay -# Pro Micro caterina -# Atmel DFU atmel-dfu -# LUFA DFU lufa-dfu -# QMK DFU qmk-dfu -# ATmega32A bootloadHID -# ATmega328p USBasp BOOTLOADER = caterina # Build Options -# change yes to no to disable -# BOOTMAGIC_ENABLE = no # Virtual DIP switch configuration MOUSEKEY_ENABLE = yes # Mouse keys EXTRAKEY_ENABLE = yes # Audio control and System control