From 97031f8d815c5187cb0e762b64119144d8c195dd Mon Sep 17 00:00:00 2001 From: e18 Date: Wed, 15 Sep 2021 09:47:17 +0500 Subject: [PATCH] resolve requested changes --- keyboards/paprikman/albacore/info.json | 2 -- .../paprikman/albacore/keymaps/default/keymap.c | 8 -------- keyboards/paprikman/albacore/keymaps/pulp/rules.mk | 3 --- keyboards/paprikman/albacore/keymaps/via/rules.mk | 3 --- keyboards/paprikman/albacore/readme.md | 12 ++++++++---- keyboards/paprikman/albacore/rules.mk | 3 +-- 6 files changed, 9 insertions(+), 22 deletions(-) diff --git a/keyboards/paprikman/albacore/info.json b/keyboards/paprikman/albacore/info.json index 98b8d46518a..494f228a325 100644 --- a/keyboards/paprikman/albacore/info.json +++ b/keyboards/paprikman/albacore/info.json @@ -2,8 +2,6 @@ "keyboard_name": "Albacore", "url": "https://github.com/paprikman/qmk_firmware/tree/master/keyboards/paprikman/albacore", "maintainer": "paprikman", - "width": 4, - "height": 2, "layouts": { "LAYOUT": { "layout": [ diff --git a/keyboards/paprikman/albacore/keymaps/default/keymap.c b/keyboards/paprikman/albacore/keymaps/default/keymap.c index e945b4c3c41..022250caf10 100644 --- a/keyboards/paprikman/albacore/keymaps/default/keymap.c +++ b/keyboards/paprikman/albacore/keymaps/default/keymap.c @@ -24,12 +24,4 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { RGB_TOG, RGB_MOD, RGB_VAI, _______, RGB_SPI, RGB_SPD, RGB_VAD ), - [2] = LAYOUT( - _______, _______, _______, - _______, _______, _______, _______ - ), - [3] = LAYOUT( - _______, _______, _______, - _______, _______, _______, _______ - ), }; diff --git a/keyboards/paprikman/albacore/keymaps/pulp/rules.mk b/keyboards/paprikman/albacore/keymaps/pulp/rules.mk index b1c00b69f57..1e5b99807cb 100644 --- a/keyboards/paprikman/albacore/keymaps/pulp/rules.mk +++ b/keyboards/paprikman/albacore/keymaps/pulp/rules.mk @@ -1,4 +1 @@ VIA_ENABLE = yes -CONSOLE_ENABLE = no -COMMAND_ENABLE = no -TAP_DANCE_ENABLE = no diff --git a/keyboards/paprikman/albacore/keymaps/via/rules.mk b/keyboards/paprikman/albacore/keymaps/via/rules.mk index b1c00b69f57..1e5b99807cb 100644 --- a/keyboards/paprikman/albacore/keymaps/via/rules.mk +++ b/keyboards/paprikman/albacore/keymaps/via/rules.mk @@ -1,4 +1 @@ VIA_ENABLE = yes -CONSOLE_ENABLE = no -COMMAND_ENABLE = no -TAP_DANCE_ENABLE = no diff --git a/keyboards/paprikman/albacore/readme.md b/keyboards/paprikman/albacore/readme.md index 6f8c87c86fb..57c113d42b2 100644 --- a/keyboards/paprikman/albacore/readme.md +++ b/keyboards/paprikman/albacore/readme.md @@ -1,16 +1,20 @@ # Albacore -*A small 7-key macropad featuring hotswap and per-key RGB* +A small 7-key macropad featuring hotswap and per-key RGB -![Albacore](https://i.imgur.com/BTPHnuQ.jpg) +![Albacore](https://i.imgur.com/BTPHnuQh.jpg) * Keyboard Maintainer: paprikman * Hardware Supported: Albacore hotswap pcb * Hardware Availability: Private group buy -Build and flash firmware (via support is considered by default): +Make example for this keyboard (after setting up your build environment): - qmk flash -kb paprikman/albacore -km via + make paprikman/albacore:default + +Flashing example for this keyboard: + + make paprikman/albacore:default:flash See the [build environment setup](https://docs.qmk.fm/#/getting_started_build_tools) and the [make instructions](https://docs.qmk.fm/#/getting_started_make_guide) for more information. Brand new to QMK? Start with our [Complete Newbs Guide](https://docs.qmk.fm/#/newbs). diff --git a/keyboards/paprikman/albacore/rules.mk b/keyboards/paprikman/albacore/rules.mk index 6942363825b..baf1b10f284 100644 --- a/keyboards/paprikman/albacore/rules.mk +++ b/keyboards/paprikman/albacore/rules.mk @@ -7,7 +7,7 @@ BOOTLOADER = atmel-dfu # Build Options # change yes to no to disable # -BOOTMAGIC_ENABLE = yes # Virtual DIP switch configuration +BOOTMAGIC_ENABLE = yes # Enable Bootmagic Lite MOUSEKEY_ENABLE = no # Mouse keys EXTRAKEY_ENABLE = yes # Audio control and System control CONSOLE_ENABLE = no # Console for debug @@ -18,7 +18,6 @@ SLEEP_LED_ENABLE = no # Breathing sleep LED during USB suspend NKRO_ENABLE = no # USB Nkey Rollover BACKLIGHT_ENABLE = no # Enable keyboard backlight functionality RGBLIGHT_ENABLE = no # Enable keyboard RGB underglow -BLUETOOTH_ENABLE = no # Enable Bluetooth AUDIO_ENABLE = no # Audio output RGB_MATRIX_ENABLE = yes