Address review comments

keyboards/elephant42/config.h

@@ -91,3 +91,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 /* disable these deprecated features by default */
 #define NO_ACTION_MACRO
 #define NO_ACTION_FUNCTION
+
+#ifndef OLED_FONT_H
+#   define OLED_FONT_H "keyboards/elephant42/lib/glcdfont.c"
+#endif

keyboards/elephant42/info.json

@@ -2,8 +2,6 @@
     "keyboard_name": "elephant42",
     "url": "https://github.com/qmk/qmk_firmware/tree/master/keyboards/elephant42",
     "maintainer": "illness072",
-    "width": 16.5,
-    "height": 5,
     "layouts": {
         "LAYOUT": {
             "layout": [

keyboards/elephant42/keymaps/default/config.h

@@ -1,22 +0,0 @@
-/*
-Copyright 2021 illness072
-
-This program is free software: you can redistribute it and/or modify
-it under the terms of the GNU General Public License as published by
-the Free Software Foundation, either version 2 of the License, or
-(at your option) any later version.
-
-This program is distributed in the hope that it will be useful,
-but WITHOUT ANY WARRANTY; without even the implied warranty of
-MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-GNU General Public License for more details.
-
-You should have received a copy of the GNU General Public License
-along with this program.  If not, see <http://www.gnu.org/licenses/>.
-*/
-
-#pragma once
-
-#ifdef OLED_ENABLE
-#   define OLED_FONT_H "keyboards/elephant42/lib/glcdfont.c"
-#endif

keyboards/elephant42/keymaps/default/keymap.c

@@ -80,7 +80,7 @@ bool process_record_user(uint16_t keycode, keyrecord_t *record) {
     return true;
 }
 
-void oled_task_user(void) {
+bool oled_task_user(void) {
     if (is_keyboard_master()) {
         static char layer_names[NUMBER_OF_LAYERS][10] = {"Default", "Lower", "Raise"};
         static char l1[] = "                \x94\x95\x96\x97";
@@ -108,5 +108,7 @@ void oled_task_user(void) {
 
         oled_write_ln_P(logo, false);
     }
+
+    return false;
 }
 #endif

keyboards/elephant42/keymaps/via/config.h

@@ -1,22 +0,0 @@
-/*
-Copyright 2021 illness072
-
-This program is free software: you can redistribute it and/or modify
-it under the terms of the GNU General Public License as published by
-the Free Software Foundation, either version 2 of the License, or
-(at your option) any later version.
-
-This program is distributed in the hope that it will be useful,
-but WITHOUT ANY WARRANTY; without even the implied warranty of
-MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-GNU General Public License for more details.
-
-You should have received a copy of the GNU General Public License
-along with this program.  If not, see <http://www.gnu.org/licenses/>.
-*/
-
-#pragma once
-
-#ifdef OLED_ENABLE
-#   define OLED_FONT_H "keyboards/elephant42/lib/glcdfont.c"
-#endif

keyboards/elephant42/keymaps/via/keymap.c

@@ -93,7 +93,7 @@ bool process_record_user(uint16_t keycode, keyrecord_t *record) {
     return true;
 }
 
-void oled_task_user(void) {
+bool oled_task_user(void) {
     if (is_keyboard_master()) {
         static char layer_names[NUMBER_OF_LAYERS][10] = {"Default", "Lower", "Raise", "Adjust"};
         static char l1[] = "                \x94\x95\x96\x97";
@@ -121,5 +121,7 @@ void oled_task_user(void) {
 
         oled_write_ln_P(logo, false);
     }
+
+    return false;
 }
 #endif

keyboards/elephant42/rules.mk

@@ -12,15 +12,11 @@ MOUSEKEY_ENABLE = no       # Mouse keys
 EXTRAKEY_ENABLE = yes       # Audio control and System control
 CONSOLE_ENABLE = no         # Console for debug
 COMMAND_ENABLE = no         # Commands for debug and configuration
-# Do not enable SLEEP_LED_ENABLE. it uses the same timer as BACKLIGHT_ENABLE
-SLEEP_LED_ENABLE = no       # Breathing sleep LED during USB suspend
-# if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work
-NKRO_ENABLE = no            # USB Nkey Rollover
+NKRO_ENABLE = no            # Enable N-Key Rollover
 BACKLIGHT_ENABLE = no       # Enable keyboard backlight functionality
 RGBLIGHT_ENABLE = no        # Enable keyboard RGB underglow
 RGB_MATRIX_ENABLE = yes
 RGB_MATRIX_DRIVER = WS2812
-BLUETOOTH_ENABLE = no       # Enable Bluetooth
 AUDIO_ENABLE = no           # Audio output
 SPLIT_KEYBOARD = yes
 OLED_ENABLE = yes