From bf1c8e57a8e9025e1c7f176f76edbea560c16e75 Mon Sep 17 00:00:00 2001 From: drashna Date: Wed, 21 Sep 2022 21:02:22 +0000 Subject: [PATCH] =?UTF-8?q?Deploying=20to=20gh-pages=20from=20@=20qmk/qmk?= =?UTF-8?q?=5Ffirmware@ea80141f6920c115bcf7993eb3173737a580e6d6=20?= =?UTF-8?q?=F0=9F=9A=80?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- pr_checklist.md | 1 + 1 file changed, 1 insertion(+) diff --git a/pr_checklist.md b/pr_checklist.md index 881f3f282c7..6d74e246a86 100644 --- a/pr_checklist.md +++ b/pr_checklist.md @@ -135,6 +135,7 @@ Also, specific to ChibiOS: - for new MCUs, a new "child" keyboard should be added that targets your newly-added MCU, so that builds can be verified - for new hardware support such as display panels, core-side matrix implementations, or other peripherals, an associated keymap should be provided - if an existing keymap exists that can leverage this functionality this may not be required (e.g. a new RGB driver chip, supported by the `rgb` keymap) -- consult with the QMK Collaborators on Discord to determine if there is sufficient overlap already +- any features adding `_kb`/`_user` callbacks must return a `bool`, to allow for user override of keyboard-level callbacks. - other requirements are at the discretion of QMK collaborators - core is a lot more subjective given the breadth of posted changes