Browse Source

[Keyboard] Flip encoder and fix weird volume behavior for Herringbone Pro (#15423)

Co-authored-by: Joel Challis <git@zvecr.com>
pull/15436/head
Ramon Imbao 2 years ago
committed by GitHub
parent
commit
c09837e092
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions
  1. +2
    -2
      keyboards/ramonimbao/herringbone/pro/config.h
  2. +2
    -0
      keyboards/ramonimbao/herringbone/pro/keymaps/via/keymap.c

+ 2
- 2
keyboards/ramonimbao/herringbone/pro/config.h View File

@ -48,8 +48,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define DIODE_DIRECTION COL2ROW
/* Encoder pin assignment */
#define ENCODERS_PAD_A { C2 }
#define ENCODERS_PAD_B { C3 }
#define ENCODERS_PAD_A { C3 }
#define ENCODERS_PAD_B { C2 }
/* Debounce reduces chatter (unintended double-presses) - set 0 if debouncing is not needed */
#define DEBOUNCE 5


+ 2
- 0
keyboards/ramonimbao/herringbone/pro/keymaps/via/keymap.c View File

@ -88,12 +88,14 @@ bool encoder_update_user(uint8_t index, bool clockwise) {
encoder_cw.pressed = true;
encoder_cw.time = (timer_read() | 1);
action_exec(encoder_cw);
wait_ms(20);
anim_sleep = timer_read32();
oled_on();
} else {
encoder_ccw.pressed = true;
encoder_ccw.time = (timer_read() | 1);
action_exec(encoder_ccw);
wait_ms(20);
anim_sleep = timer_read32();
oled_on();
}


Loading…
Cancel
Save