I tried the codebase against the new esp-idf 4 alpha code, and
the build didn't have exception handling enabled by default.
I saw no problems with modifying the code to not raise exceptions,
so I did so to be future-proof.
The exception cases were cases that should not happen anyway,
because the input that could trigger the exception has already
been validated on beforehand by the Python-based code generation.
Fixes#10
"When changing RGB color settings, while night light mode is active,
transitions don't look good. On many of the transitions, the light
level shows a significant drop."
This commit fully suppresses transitions when the light is in
night light mode.
The reasoning behind this can be found in this issue:
https://github.com/mmakaay/esphome-yeelight_bs2/issues/7
When you are already using a previous version of the firmware,
then note that the following changes are necessary:
* Update to the latest version of the custom component code.
* Rename your folder `custom_components/yeelight_bs2` to
`custom_components/xiaomi_bslamp2`
* Update your yaml config by changing all occurrences of `yeelight_bs2`
into `xiaomi_bslamp2`
The links to the github repository will remain functional after
the renaming operation, so it's not required to grab a fresh clone.
For example: `id(${id_light_mode}).state == "night"`
This is used in the example.yaml to turn off the illumination
of the front panel, when the lamp goes into night light mode.
A HUB component was introduced. This HUB component has all the knowledge
about the Yeelight Bedside Lamp 2 hardware. It known what pins are used,
that PWM frequencies to use, what pins to switch in binary mode, etc. etc.
No configuration is required for this HUB component. It's automatically
loaded when the light component is loaded. The light component will use the
HUB component to access the pins that are required for driving the LED
circuitry.
Note that this simplifies the configuration by A LOT. There's no need
anymore to configure the pinouts in the YAML file. This is a logical route
to take, since we're talking about a factory-produced PCB with a soldered on
ESP32 chip, which uses the same GPIO's and settings on all produced devices
(I presume). It would be quite redundant to force every user into
configuring these pinouts themselves.
** Beware to update your device yaml configuration **
There are a few pinouts left to move into the HUB. I will do that in the
next commit. Your device yaml configuration can be simplified along with
these changes. Some of the keys in the existing light configuration block
will no longer work and will have to be removed (red, green, blue, white).
** Further development **
The HUB will be extended make it the central component that also handles
the I2C communication. This way, there is a central place to regulate the
traffic to and from the front panel. We will be able to build upon this
by implementing extra, fully separated components that handle for example
the front panel light level, the power button, the color button and
the slider.
** Interrupt handler for the I2C IRQ trigger pin **
One requirement for the I2C communication has already been implemented: an
interrupt handler for the GPIO that is used by the front panel to signal the
ESP that a new touch or release event is avilable to be read.
It doens't do anything functionally right now, but if you watch the log
file, you will see that touch events are detected and that they trigger some
log messages.
"ID 'bedlight' of type yeelight::bs2::YeelightBS2LightState doesn't inherit
from light::LightState. Please double check your ID is pointing to the
correct value."
Maurice Makaay
Maurice Makaay